Stop counting draft PRs as open Dependicus items for review#63
Merged
Conversation
The previous pass over-corrected and made searchDependicusIssues drop every pull request returned by GitHub's issues endpoint. That left notification bots with no way to distinguish a fresh, ready-for-review PR from a half-finished draft, and they kept honking '54 open Dependicus PRs' because they were still reaching for the count via other channels. Now the helper: - Skips draft PRs only — a draft is explicitly not open for review. - Returns ready-for-review PRs alongside regular issues, with a new isPullRequest flag so callers can tell them apart. - Still skips anything flagged as a draft defensively. The reconciler uses the new flag to keep treating PR titles as 'something already exists, don't create a duplicate', while never mutating the PR via octokit.issues.update (which would clobber the PR's title and body since GitHub gives PRs and issues a shared numbering scheme). So the goose finally stops honking at perfectly good ducks paddling in the review pond — only the ducklings still tucked under the wing get left alone. Co-authored-by: Angela Gong <anjoola@users.noreply.github.com>
CI's lockfile-consistency check started failing because semver@7.8.1 and undici@6.26.0 were published upstream and the ^7.3.5 / ^6.25.0 ranges now resolve to the newer versions. Running 'mise update-all-lockfiles' produces only this lockfile refresh — no source changes. Co-authored-by: Angela Gong <anjoola@users.noreply.github.com>
rzeng95
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing
The previous pass over-corrected:
searchDependicusIssueswas changed to drop every pull request returned by GitHub's issues endpoint, draft or not. That made the notification bot's job impossible — it couldn't see the open Dependicus PRs that legitimately needed review, and it kept honking:package: 54 open Dependicus PRs for Editor Media Managementbecause the count was still being padded by drafts coming in from elsewhere.This PR puts
searchDependicusIssuesback where it belongs:isPullRequestboolean so callers can tell them apart.The reconciler picks up the new flag and uses it to keep treating a PR title as "something already exists, don't create a duplicate", while never mutating the PR via
octokit.issues.update(which would clobber the PR's title and body, since GitHub gives PRs and issues a shared numbering scheme).Tests
isPullRequest: true.isPullRequest: false.HtmlWriter.test.tsfailure onbrowser-bundle.asset.jsreproduces onmainwithout my changes — it needs a build first).Waterfowl moment
The goose finally stops honking at perfectly good ducks paddling in the review pond. Only the ducklings still tucked under the wing get left alone.
Slack Thread