Skip to content

test: migrate VirtualMachineCancelMigration e2e test to new framework#2333

Open
eofff wants to merge 11 commits into
mainfrom
test/vm-migration-cancel-test-new-framework
Open

test: migrate VirtualMachineCancelMigration e2e test to new framework#2333
eofff wants to merge 11 commits into
mainfrom
test/vm-migration-cancel-test-new-framework

Conversation

@eofff
Copy link
Copy Markdown
Contributor

@eofff eofff commented May 8, 2026 •
edited
Loading

Description

Migrate VirtualMachineCancelMigration e2e test to new framework.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: chore
summary: Migrate VirtualMachineCancelMigration e2e test to new framework.
impact_level: low

@eofff eofff added this to the v1.9.0 milestone May 8, 2026
@eofff eofff force-pushed the test/vm-migration-cancel-test-new-framework branch from 90cf558 to 3428f03 Compare May 8, 2026 11:31
@eofff eofff requested a review from hardcoretime May 8, 2026 12:09
@eofff eofff marked this pull request as ready for review May 8, 2026 12:09
@eofff eofff requested a review from Isteb4k as a code owner May 8, 2026 12:09
hardcoretime
hardcoretime requested changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@hardcoretime hardcoretime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check all descriptions for English grammar.

Comment thread test/e2e/vm/migration_cancel.go Outdated
Comment thread test/e2e/vm/migration_cancel.go Outdated
Comment thread test/e2e/vm/migration_cancel.go Outdated
Comment thread test/e2e/vm/migration_cancel.go Outdated
Comment thread test/e2e/internal/util/vm.go Outdated
Comment thread test/e2e/vm/migration_cancel.go Outdated
Comment thread test/e2e/vm/migration_cancel.go Outdated
Comment thread test/e2e/vm/migration_cancel.go Outdated
@eofff eofff force-pushed the test/vm-migration-cancel-test-new-framework branch 3 times, most recently from 0b5128f to d492d7d Compare May 12, 2026 21:26
@eofff eofff requested a review from hardcoretime May 12, 2026 21:33
@eofff eofff force-pushed the test/vm-migration-cancel-test-new-framework branch from d492d7d to d19d423 Compare May 12, 2026 21:34
hardcoretime
hardcoretime requested changes May 13, 2026
View reviewed changes
Comment thread test/e2e/vm/migration_cancel.go Outdated
Comment thread test/e2e/vm/migration_cancel.go
Expect(err).NotTo(HaveOccurred())

By("Wait for stress-ng to increase memory pressure")
Consistently(func() error {
Copy link
Copy Markdown
Contributor

@hardcoretime hardcoretime May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if migration is queued?

Copy link
Copy Markdown
Contributor Author

@eofff eofff May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added check error log before checking migration state

Comment thread test/e2e/vm/migration_cancel.go Outdated
Comment thread test/e2e/vm/migration_cancel.go Outdated
@eofff eofff force-pushed the test/vm-migration-cancel-test-new-framework branch from 5d6c7f9 to c2b3e2d Compare May 13, 2026 12:37
@eofff eofff added e2e/run Run e2e test on cluster of PR author and removed e2e/run Run e2e test on cluster of PR author labels May 13, 2026
@eofff eofff force-pushed the test/vm-migration-cancel-test-new-framework branch from c2b3e2d to fa0914f Compare May 13, 2026 13:37
@eofff eofff requested a review from hardcoretime May 13, 2026 15:42
Valeriy Khorunzhin added 10 commits May 14, 2026 01:05
fix
d25701b 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
new framework
c32b34a 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
refactoring
48f617e 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
fix linter
7700a96 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
agent ready
1f2fddd 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
linter
b247d4d 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
resolve
bafc990 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
resiolve 2
ef15709 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
resolve 2
d115a56 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
remove useless check
3ed5082 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff force-pushed the test/vm-migration-cancel-test-new-framework branch from 2aed18c to 3ed5082 Compare May 13, 2026 22:06
update config.go
6fa0c18 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

@hardcoretime hardcoretime Awaiting requested review from hardcoretime

Requested changes must be addressed to merge this pull request.

Assignees

@eofff eofff

Labels

None yet

Projects

None yet

Milestone

v1.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@eofff @hardcoretime