Bugfix in TPCFastTransform with reduced metadata#141
Merged
davidrohr merged 3 commits intodavidrohr:dev_pull_request6from Apr 21, 2026
Merged
Bugfix in TPCFastTransform with reduced metadata#141davidrohr merged 3 commits intodavidrohr:dev_pull_request6from
davidrohr merged 3 commits intodavidrohr:dev_pull_request6from
Conversation
Owner
|
fix works, thx a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi David, Ruben.
@davidrohr, @shahor02
This PR fixes the commit bd7be4f9a69b37b50ee0fcd3c94b58a6b346d4cb
"TPCFastTransform: reduce the metadata: the same spline setup for all the sectors"
The TPCFastSpaceChargeCorrection and the TPCFastTransformPOD now show the same results everywhere on the CPU.
I didn't test it on the GPU, but it must work. David, please check.
There is a little difference (of the order of 1.e-6 at max) in getCorrectionYZatRealYZ(..) between the POD and the standard version of the SC correction.
I assume the difference is due to differences in the code optimization.
This difference was not there before. It appears right after the commit b90942c92ed3bc599e157472db21585069483325
"TPCFastTransform: remove row-wise max correction values"
It disappears again when I disable the check for the large values in getCorrectionYZatRealYZ() by commenting out the corresponding lines:
https://github.com/sgorbuno/AliceO2/blob/PR21.04/GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h#L500
https://github.com/sgorbuno/AliceO2/blob/PR21.04/GPU/TPCFastTransformation/TPCFastTransformPOD.h#L362
Interesting: in my test, the check for large values is never triggered. But just the presence of this check in the code changes the calculations, apparently.