docs(skill): Harden ruleset-builder against FK-cascade and mask-type errors#7
Merged
kw-datamasque merged 3 commits intomainfrom May 6, 2026
Merged
Conversation
kw-datamasque
force-pushed
the
docs/improve-ruleset-builder-skill
branch
from
8a6cc7f to
5da89d0
Compare
kw-datamasque
force-pushed
the
docs/improve-ruleset-builder-skill
branch
7 times, most recently
from
be0b417 to
57f7d6b
Compare
kw-datamasque
changed the title
kw-datamasque
force-pushed
the
docs/improve-ruleset-builder-skill
branch
2 times, most recently
from
8b3248f to
f5a94f3
Compare
beneboy
reviewed
May 5, 2026
| 3. **Clean structure** — `skip_defaults`, no doc blocks, validated | ||
|
|
||
| **4-step process. Complete all 4 steps. Report after each step before proceeding.** | ||
| The deterministic masks `imitate_unique`, `imitate_uuid`, and `from_unique_imitate` cascade — share one mask config across both sides of every FK; never skip IDs or invent linking parameters. |
Collaborator
There was a problem hiding this comment.
Does this suggest to add the mask on both the PK/FK columns instead of just PK and it cascades?
Collaborator
Author
There was a problem hiding this comment.
Restated that the PK is masked, and result cascades to FKs
kw-datamasque
changed the title
kw-datamasque
force-pushed
the
docs/improve-ruleset-builder-skill
branch
from
f5a94f3 to
95b1eee
Compare
kw-datamasque
commented
May 5, 2026
Collaborator
Author
There was a problem hiding this comment.
Will apply following small fixes before merge:
- Change Step 0-4 to Step 1-5
- Align tables in SKILL.md
…errors Targets two observed agent failure modes in the ruleset-builder skill: - FK cascade misunderstanding (skipping IDs, inventing source_table-style params) - Mask-type hallucination (from_random_words, hash_text, etc.) Adds references/fk-cascade.md documenting that the engine auto-replicates the parent PK rule onto every FK column at runtime when the mask is one of the cascading masks (imitate_unique, imitate_uuid, imitate_nz_ird). Reinforces the existing Mask Types Quick Reference as a closed list and adds a kill-table of common hallucinations. Fixes missing --type flag on dm rulesets validate.
kw-datamasque
force-pushed
the
docs/improve-ruleset-builder-skill
branch
from
95b1eee to
320a30a
Compare
beneboy
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens
ruleset-builderskill against two agent failure modes:imitate_unique,imitate_ird, orimitate_uuidwe only need to target the PK (FK will cascade).mask_unique_keyand FUI are deprecated.from_random_words,hash_text, etc.)Adds
references/fk-cascade.md. Reinforces the existing masks as a closed list and adds a list of common hallucinations. Fixes missing--typeflag ondm rulesets validate.Out of scope
dm rulesets generatebroken (dict vs pydantic model)dm rulesets validatepasses when imported library doesn't exist