feat(rs-dpp): unify JSON/Value conversion traits + comprehensive round-trip tests

[shumkov]

Summary

Unification work for the canonical JsonConvertible / ValueConvertible traits across packages/rs-dpp. Two passes:

Pass 1 — added trait impls to ~80 domain types (commit 9f23d675af). All types now expose the canonical conversion surface.

Pass 2 — added 197 round-trip tests using non-default fixtures + per-property assertions per the new test convention. Surfaced 3 platform_value bugs that were previously silent.

Test results

• 3619 dpp lib tests pass, 18 ignored, 0 failed (no regressions vs. base branch).
• 197 dedicated json_convertible_tests across ~95 types.
• 12 of the 197 are #[ignore]d — each documents either a real bug found or a structural issue (BLS keys, untagged-enum ambiguity, known-broken serde).

Bugs surfaced (logged in docs/json-value-unification-plan.md §10b)

1. OutPoint round-trip via platform_value::Value::Map fails — affects ChainAssetLockProof, AddressFundingFromAssetLockTransition, ShieldFromAssetLockTransition. JSON works.
2. [u8; N] fixed-array fields with custom serializers fail platform_value round-trip ("Invalid symbol 17, offset 0") — affects ExtendedBlockInfo signature and all 5 shielded transitions' Orchard fields. JSON works.
3. DataContract document_schemas lose sized integer types via JSON round-trip (U32(63) → U64(63), I32(0) → U64(0)) — Critical-1 manifestation; affects every state transition embedding a DataContract. Value round-trip works.

Convention added

Every J/V test follows docs/json-value-unification-plan.md §8:

1. Round-trip via to_json → from_json (and same for value).
2. Non-default fixture with distinguishable values per field.
3. Per-property assertions on the recovered struct — catches silent field drops, type narrowing, custom-PartialEq quirks.
4. Tagged-enum $formatVersion preservation test where applicable.

Fixtures source priority: hand-built struct literals > random_* constructors > from_* factories > crate::tests::fixtures::* helpers > Default::default() only for unit-only enums.

Code improvements

• Derived PartialEq on StateTransitionProofResult + StoredAssetLockInfo (was missing, blocked round-trip assert_eq).

Out of scope (genuinely residual — needs upstream work)

• ValidatorSet — needs real BLS public key construction (crypto setup).
• ExtendedDocument — Critical-3 known-broken serde (writes version, reads $version).
• StateTransition umbrella — serde(untagged), deserialize ambiguity (logged #[ignore]).

Docs

• docs/json-value-conversion-inventory.md — pre-pass-1 structural inventory.
• docs/json-value-unification-plan.md — full plan with phases, bug log, lessons learned, fixture conventions.

Test plan

• Reviewer runs cargo test -p dpp --features=json-conversion,value-conversion,serde-conversion and sees 3619 pass / 0 fail.
• Reviewer skims docs/json-value-unification-plan.md §10b for the 3 surfaced bugs and decides priority for follow-up fix.
• Reviewer confirms the test convention in §8 is appropriate for the project's testing style.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e13f9bbf-da30-41b2-b5c2-780f5d2fc462

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/json-convertible-address-transitions

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}