Skip to content

gnu.cfg: Add support for some built-in functions to check overflow#8449

Open
gagachang wants to merge 1 commit intocppcheck-opensource:mainfrom
gagachang:add-gnu-overflow
Open

gnu.cfg: Add support for some built-in functions to check overflow#8449
gagachang wants to merge 1 commit intocppcheck-opensource:mainfrom
gagachang:add-gnu-overflow

Conversation

@gagachang
Copy link
Copy Markdown
Contributor

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some tests for each function here:

test/cfg/gnu.c

@gagachang
Copy link
Copy Markdown
Contributor Author

please add some tests for each function here:

test/cfg/gnu.c

I've added test cases. Please see if they are reasonable.

Comment thread cfg/gnu.cfg
<arg nr="2" direction="in">
<not-uninit/>
</arg>
<arg nr="3" direction="out">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrchr-github sorry.. could you say is this correct? or should there be an indirection?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pointer output arguments should have direction="out" indirect="1".
The by-value input arguments should be fine as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants