Skip to content

[2026-03 LWG Motion 28] P3826R5 Fix Sender Algorithm Customization#8919

Merged
tkoeppe merged 4 commits intocplusplus:mainfrom
eisenwave:motions-2026-03-lwg-28
Apr 20, 2026
Merged

[2026-03 LWG Motion 28] P3826R5 Fix Sender Algorithm Customization#8919
tkoeppe merged 4 commits intocplusplus:mainfrom
eisenwave:motions-2026-03-lwg-28

Conversation

@eisenwave
Copy link
Copy Markdown
Member

@eisenwave eisenwave commented Apr 5, 2026

@eisenwave eisenwave added this to the post-2026-03 milestone Apr 5, 2026
@eisenwave
Copy link
Copy Markdown
Member Author

eisenwave commented Apr 5, 2026

As mentioned on the issue, this PR has a merge conflict with #8818. Some heavy massaging may be needed.

ericniebler
ericniebler reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ericniebler ericniebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this pr is incomplete. i'll come back and review the rest when its done.

Comment thread source/exec.tex Outdated
Comment thread source/exec.tex
Comment thread source/exec.tex
Comment thread source/exec.tex Outdated
Comment thread source/exec.tex
Comment thread source/exec.tex
@ericniebler ericniebler mentioned this pull request Apr 8, 2026
Open
@eisenwave
Copy link
Copy Markdown
Member Author

eisenwave commented Apr 19, 2026

image

I suspect the first "expression-equivalent" should also be turned into "equivalent" here.

@eisenwave
Copy link
Copy Markdown
Member Author

eisenwave commented Apr 19, 2026

The paper is simplifying a bunch of code blocks into only containing an short expression make-sender(...). I've decided to turn those into \tcode for consistency, even if the paper doesn't always indicate that should simplification should take place.

I don't think it makes much sense to have a code block for like 20 characters.

@eisenwave eisenwave marked this pull request as ready for review April 19, 2026 05:58
@eisenwave
Copy link
Copy Markdown
Member Author

eisenwave commented Apr 19, 2026

The changes are all there now, but I haven't proof-read anything yet and there are likely lots of errors.

@eisenwave eisenwave force-pushed the motions-2026-03-lwg-28 branch from 6c6bc9d to 6cc9e5b Compare April 19, 2026 06:54
@tkoeppe tkoeppe force-pushed the motions-2026-03-lwg-28 branch from 6407e09 to 1936452 Compare April 19, 2026 19:43
@eisenwave
Copy link
Copy Markdown
Member Author

eisenwave commented Apr 19, 2026

Ah right, I never ended up doing the change in #8919 (comment); that should probably be done as an extra commit attached to this PR.

@tkoeppe tkoeppe force-pushed the motions-2026-03-lwg-28 branch from 1936452 to 199c651 Compare April 19, 2026 23:55
@tkoeppe
Copy link
Copy Markdown
Contributor

tkoeppe commented Apr 20, 2026

Ah right, I never ended up doing the change in #8919 (comment); that should probably be done as an extra commit attached to this PR.

Done.

eisenwave and others added 2 commits April 20, 2026 01:05
@tkoeppe tkoeppe force-pushed the motions-2026-03-lwg-28 branch from 346140a to 68e8176 Compare April 20, 2026 00:06
tkoeppe added 2 commits April 20, 2026 01:06
@tkoeppe
[exec.sync.wait{,.var}] Move "following:" expressions inline.
9fd5987
@tkoeppe
[exec.sync.wait] Change "expression-equivalent" to just "equivalent".
69f22f6 
This was a mistake in the paper. The corresponding change in
[exec.sync.wait.var] made this change, too.
@tkoeppe tkoeppe force-pushed the motions-2026-03-lwg-28 branch from 68e8176 to 69f22f6 Compare April 20, 2026 00:06
@tkoeppe tkoeppe merged commit 566aeee into cplusplus:main Apr 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

+1 more reviewer

@ericniebler ericniebler ericniebler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

post-2026-03

Development

Successfully merging this pull request may close these issues.

[2026-03 LWG Motion 28] P3826R5 Fix Sender Algorithm Customization P3826 R3 Fix Sender Algorithm Customization

3 participants

@eisenwave @tkoeppe @ericniebler