[lib] Remove redundant typename in default template arguments#8426
Open
frederick-vs-ja wants to merge 1 commit intocplusplus:mainfrom
Open
[lib] Remove redundant typename in default template arguments#8426frederick-vs-ja wants to merge 1 commit intocplusplus:mainfrom
typename in default template arguments#8426frederick-vs-ja wants to merge 1 commit intocplusplus:mainfrom
Conversation
frederick-vs-ja
force-pushed
the
no-default-template-argument-typename
branch
from
90fcb72 to
19b236f
Compare
Member
|
Marking this P2 because this implements the decisions made in https://github.com/cplusplus/nbballot/issues/706 (so it's a de-facto guidelines violation now) |
Member
I thought the decision (and the topic of the NB comment) was to remove |
eisenwave
added
P3-Other
frederick-vs-ja
force-pushed
the
no-default-template-argument-typename
branch
from
19b236f to
b9dd79b
Compare
frederick-vs-ja
force-pushed
the
no-default-template-argument-typename
branch
from
b9dd79b to
b24dc63
Compare
Member
|
@jwakely , I think this de-clutters the presentation. Could you please ask LWG at the next telecon whether there are any objections to doing that? (Or just decide yourself.) |
Affected sections and components: - [utility.syn] - `constant_wrapper` - [format.formattable] - _`formattable-with`_ - [re.syn] - `regex_iterator` - `regex_token_iterator` - [re.regiter.general] - `regex_iterator` - [re.tokiter.general] - `regex_token_iterator` - [simd.syn] - `simd::alignment` - `simd::alignment_v` - [simd.traits] - `simd::alignment` - [time.syn] - `time_point` - [time.point.general] - `time_point`
frederick-vs-ja
force-pushed
the
no-default-template-argument-typename
branch
from
b24dc63 to
6c268c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3637. We did such changes when applying P2248R8.
Affected sections and components:
constant_wrapperformattable-withregex_iteratorregex_token_iteratorregex_iteratorregex_token_iteratorsimd::alignmentsimd::alignment_vsimd::alignmenttime_pointtime_point