Trim dependencies#418
Open
jnoordsij wants to merge 4 commits intocomposer:mainfrom
Open
Conversation
Member
|
But to what end? Image size is not really a concern for the images that are not binary-only. If end users have a real need for a lean image, they can make their own. |
Contributor
Author
|
Yeah fair, the benefits are very marginal, it just saves a slight bit of build time and network load for dependencies that seem to be entirely obsolete nowadays from what I can gather. And moreover it also would serve (at least it did for me) as a bit of an example which tooling might be relevant when only using the binary in your own image. But I do admit there's no certainty it will not break anything, so if some parts or all of this seems to superfluous, I can also fully understand not bothering with this further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to trim dependencies to reduce image size and build time. The efforts are based on the discussion here and subsequent changes in composer/composer#12580. From what I've been able to deduce myself and based on the discussions, all of this can be dropped without any impact (or otherwise very minimal impact).
I've deliberately only opted to target the
latestimage and it may even be worth considering doing this only from 2.10 forwards, to even further reduce the potential scope of impact.Note that dropping
mercurialcould also be considered to heavily reduce image size, being responsible for most of the image size (in comparison to the PHP base image), however given that I see it still being valid for some usecases, keeping it around makes some sense.