Feat: blog post - Content Localization#301
Conversation
✅ Deploy Preview for compilerla ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jgravois
left a comment
jgravois
left a comment
There was a problem hiding this comment.
https://deploy-preview-301--compilerla.netlify.app/blog/2026/content-localization
this is looking good as far as i'm concerned.
| .blog_post p:last-child:not(li p) { | ||
| margin-bottom: 0; | ||
| } |
There was a problem hiding this comment.
not a blocker, but i tried setting margin-bottom: 0 manually on the last <p> tag in the unordered list to try and simulate what things would look like without this modification and it didn't appear to be problematic.
are you seeing something different locally?
There was a problem hiding this comment.
Yeah, so because each <li> contains a <p>, each of those <p> elements is the last-child. With the original CSS rule of
.blog_post p:last-child {
margin-bottom: 0;
}
this resulted in a really tight list, spacing-wise:
My sense on the .blog_post p:not(:last-child)/.blog_post p:last-child rules is that they were more for controlling the spacing between the main <p> elements of the post rather than <p>s that are nested in lists, so I figured adding the :not(li p) here was reasonable. Open to other ideas for making this more readable or intuitive!
There was a problem hiding this comment.
no complaints here. thanks for confirming that my (lazy) simulation was indeed not reflective of how things look without the new modifier 👍
images are laid out vertically on small screens
we chose not to reuse the one from the Remix blog post because this post is not as transit-themed. this outro is more general and oriented around digital services.
angela-tran
force-pushed
the
feat/content-localization-blog-post
branch
from
dac5359 to
e27a015
Compare
this was motivated by noticing that there was extra space in the case of an image followed by an `h2` when compared to a paragraph followed by an `h2`, which has its rule via `.blog_post p + h2`. I don't know if this change would break some part of the design, but from what I see with our existing blog posts, there aren't any realized instances of style regression.
3 participants
ClickUp task: https://app.clickup.com/t/86b96889r