♻️ refactor(line-items): refactor child components and add 100% coverage tests#777
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
acasazza
added
enhancement
- Fix import sorting across all spec files (auto-fixed) - Replace `any` types in helpers.tsx with proper SDK types (Partial<LineItem>, Partial<LineItemOption>) - Fix LineItem.spec.tsx: alias SDK LineItem as LineItemResource to avoid name collision - Fix LineItemImage.spec.tsx: use ChildrenFunction<TLineItemImage> instead of `as any` cast; remove `undefined as any` - Fix LineItemOptions.tsx: use `o.sku_option?.id` (static SDK attribute) instead of `(o as any).skuOption?.()`; use `o.id` as map key to avoid noArrayIndexKey warning - Fix helpers.tsx: replace `skuOption()` method mock with `sku_option` static attribute to match SDK type - All 70 tests passing, no Biome errors Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
commit: |
- Fix import sorting in LineItemCode, LineItemField, LineItemName, LineItemQuantity, LineItemRemoveLink, LineItemsContainer - Fix LineItems.tsx formatter (line break in ternary) - LineItemRemoveLink: change <a href="#"> to <button type="button"> (a11y: useValidAnchor) - LineItemsContainer: Record<string, any> → Record<string, unknown> - LineItemsContainer: add addResourceToInclude to useEffect deps Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
gciotola
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useState+useEffectpatterns withuseMemoinLineItemAmount,LineItemsCount,LineItemsEmptyas any→ElementTypetyping inLineItemOptionandLineItemOptionsLineItemOptions: usesku_option.idstatic SDK attribute instead of dynamicskuOption()accessorLineItemRemoveLink: replace<a href="#">with<button type="button">(a11y fix)LineItemsContainer(deprecated): fixnoExplicitAny, import sorting,useEffectdependencyVerification
Notes
LineItemsContainer.tsxis deprecated (marked@deprecated) — minimal fixes onlyPartial<LineItem>,Partial<LineItemOption>) — noanyline_itemsfolder