Skip to content

Improve Modal component#1145

Merged
pfferrari merged 2 commits into
mainfrom
feat/621-improve-modal
May 27, 2026
Merged

Improve Modal component#1145
pfferrari merged 2 commits into
mainfrom
feat/621-improve-modal

Conversation

@pfferrari
Copy link
Copy Markdown
Contributor

Closes commercelayer/issues-app/issues/621

What I did

Improved Modal component by:

  • Refactoring Modal to rely on dialog element for better accessibility and event management
  • Adding dismissible prop to enable Modal dismissibility via backdrop click or Esc key press
  • Adding Modal unit test suite

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 27, 2026

Deploy Preview for commercelayer-app-elements ready!

Name Link
🔨 Latest commit c130637
🔍 Latest deploy log https://app.netlify.com/projects/commercelayer-app-elements/deploys/6a16f6f3ded9fb0008176d5a
😎 Deploy Preview https://deploy-preview-1145--commercelayer-app-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pfferrari pfferrari self-assigned this May 27, 2026
@pfferrari pfferrari added the enhancement New feature or request label May 27, 2026
@gciotola
Copy link
Copy Markdown
Contributor

@copilot can you add a story to showcase the new dismissible prop on the Modal component? Add just one story.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 27, 2026

@copilot can you add a story to showcase the new dismissible prop on the Modal component? Add just one story.

Implemented in commit c130637: added one new Dismissible Modal story in Modal.stories.tsx to showcase closing via backdrop click and Esc.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 27, 2026

npm i https://pkg.pr.new/commercelayer/app-elements/@commercelayer/app-elements@1145

commit: c130637

@pfferrari pfferrari merged commit 28ad8d1 into main May 27, 2026
7 checks passed
@pfferrari pfferrari deleted the feat/621-improve-modal branch May 27, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants