Fix unstyled link flash in external link cards#2407
Open
tf wants to merge 1 commit intocodevise:masterfrom
Open
Fix unstyled link flash in external link cards#2407tf wants to merge 1 commit intocodevise:masterfrom
tf wants to merge 1 commit intocodevise:masterfrom
Conversation
Wrapping the whole card in an anchor broke SSR hydration when the card contained other links (file-rights credits or inline description links): the HTML parser auto-closes the outer anchor when it sees a nested one, producing a different DOM than React renders, so cards briefly appeared without link styling until hydration completed. Replace the outer anchor with one of three inner links chosen by card content: the title when present, the image when the card shows only a thumbnail, or a visually hidden "More" fallback otherwise. Each inner link is a sibling of any other anchor, so the markup is valid and hydration is seamless. Inline description links now work without the outer anchor hijacking drags or forcing nested anchors. Editor mode keeps the outer EditableLink wrapper so the link action button behaves as before.
tf
force-pushed
the
teaser-link-improvements
branch
from
d9ccd74 to
2a3e64b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapping the whole card in an anchor broke SSR hydration when the card contained other links (file-rights credits or inline description links): the HTML parser auto-closes the outer anchor when it sees a nested one, producing a different DOM than React renders, so cards briefly appeared without link styling until hydration completed.
Replace the outer anchor with one of three inner links chosen by card content: the title when present, the image when the card shows only a thumbnail, or a visually hidden "More" fallback otherwise. Each inner link is a sibling of any other anchor, so the markup is valid and hydration is seamless.
Inline description links now work without the outer anchor hijacking drags or forcing nested anchors. Editor mode keeps the outer EditableLink wrapper so the link action button behaves as before.