Merged
Conversation
…mpatibility
Effect 3.x uses unique Symbol for TypeId; Effect 4.x uses the plain string
'~effect/Effect'. Running Effect.runPromise from a bundled 3.x instance on
a 4.x Effect object fails with 'Not a valid effect: {}' because isEffect()
uses a Symbol lookup that cannot find the string-keyed property.
Pinning effect to 4.0.0-beta.48 (matching opencode) and adding a local
tsconfig.json with moduleResolution:bundler so DTS generation resolves the
package exports correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix cross-module Effect incompatibility
Effect 3.x uses unique Symbol for TypeId; Effect 4.x uses the plain string '~effect/Effect'. Running Effect.runPromise from a bundled 3.x instance on a 4.x Effect object fails with 'Not a valid effect: {}' because isEffect() uses a Symbol lookup that cannot find the string-keyed property.
Pinning effect to 4.0.0-beta.48 (matching opencode) and adding a local tsconfig.json with moduleResolution:bundler so DTS generation resolves the package exports correctly.