Conversation
…ons, buildHarnessWriters, loadExtensions Add Zod schema and AdeExtensions type to types.ts (type definitions allowed in RED phase). Add zod to @codemcp/ade-core deps, jiti to @codemcp/ade-cli deps. Tests cover schema validation, catalog merging, harness writer extension, and extension file loading.
…s, buildHarnessWriters - Add mergeExtensions(catalog, extensions) to packages/core — merges facet contributions and new facets without mutating the original catalog - Export AdeExtensions, AdeExtensionsSchema, mergeExtensions from @codemcp/ade-core - Add buildHarnessWriters(extensions) to @codemcp/ade-harnesses — appends extension harness writers after built-ins without mutating allHarnessWriters - Create packages/cli/src/extensions.ts with loadExtensions(projectRoot) — discovers ade.extensions.ts/.mjs/.js, validates via Zod, loads .ts files via jiti - Wire loadExtensions into CLI index.ts — setup and install commands now consume extensions - Accept harnessWriters as parameter in runSetup and runInstall for testability - Add ade.extensions.mjs SAP example file in repo root - Fix install.spec.ts mock to include allHarnessWriters with vi.hoisted mockInstall
…rder tests Add zod 4.3.6 to pnpm workspace catalog so it resolves correctly when root Vitest transforms @codemcp/ade-core source files. Reference catalog: from core and cli package.json. Add zod as root devDependency. Also replace the placeholder search-order test with two real tests: - loads .js fallback when only .js exists - prefers .mjs over .js when both exist
…and knowledge Verify the full pipeline: an AdeExtensions facet contribution with an inline skill + knowledge recipe, merged via mergeExtensions, run through runSetup, produces the expected SKILL.md in .ade/skills/, knowledge_sources in the lock file, and the extension option recorded in config.yaml.
Add test simulating npx-from-different-cwd: loadExtensions(userProjectDir)
loads the user's file; loadExtensions(cliPackageDir) returns {} — proving
the CLI install location is never consulted.
Also add docs/guide/extensions.md: terse guide covering facetContributions,
new facets, harness writers, validation, and upstream-compatibility table.
mrsimpson
force-pushed
the
extensibility
branch
from
07e91e2 to
b868966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.