Skip to content

hearing held checks#2095

Merged
mertbagt merged 7 commits intocodeforboston:mainfrom
mertbagt:hearing_held
Apr 29, 2026
Merged

hearing held checks#2095
mertbagt merged 7 commits intocodeforboston:mainfrom
mertbagt:hearing_held

Conversation

@mertbagt
Copy link
Copy Markdown
Collaborator

@mertbagt mertbagt commented Apr 5, 2026

Summary

Issue #2077

  • need to add translation

  • some bills have "Hearing rescheduled to MM/DD/YYYY..." and should probably get handled by this issue (see H5000)

Checklist

  • On the frontend, I've made my strings translate-able.
  • [n/a] If I've added shared components, I've added a storybook story.
  • [n/a] I've made pages responsive and look good on mobile.
  • [n/a] If I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

Screenshots

image

fzero-super-nintendo

Known issues

none

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. Go to /bills/194/H5008
  2. verify that banner says "Hearing Held"

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maple-dev Ready Ready Preview, Comment Apr 29, 2026 0:00am

Request Review

const handleCloseBillHistory = () => setShowBillHistory(false)
const history = last(bill.history)
const today = new Date().toISOString()
const target1 = "Hearing scheduled for "
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for at least the medium-term, but we'll need to revisit this when we revisit translations.

@mertbagt mertbagt merged commit 5f3b092 into codeforboston:main Apr 29, 2026
8 checks passed
@mertbagt mertbagt deleted the hearing_held branch April 29, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants