Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1667 +/- ##
==========================================
- Coverage 54.68% 54.18% -0.50%
==========================================
Files 336 340 +4
Lines 27501 27835 +334
==========================================
+ Hits 15039 15083 +44
- Misses 12462 12752 +290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Also, there should be some documentation of the controller communication format. Also, i'm not sure i like the name: i think it'd be more descriptive to call this something like "DynamicInteractive" to emphasize that it spawns solutions dynamically. (and then Communication could be renamed to Interactive, which is what it really is. though we'd probably need to keep the name Communication as an alias.) |
The plan is to have Interactive eventually also take over the tasks that we currently do with Communication, so I am happy with the "Interactive" task name. As for documentation: that will come, I would like first to make sure that we agree the implementation is sensible. |
prandla
left a comment
There was a problem hiding this comment.
i think the implementation in general is fine now. interactive_keeper.py doesn't really spark joy for me, but i don't know how to improve it much. (aside from the one comment i left in it)
5060e23 to
3ed43ef
Compare
gollux
left a comment
There was a problem hiding this comment.
I have several nitpicking comments, but overall I like it. However, there should be some documentation on how to use the task type.
f6fbc3a to
df9f99d
Compare
|
Also, I wonder if we should allow setting the solutions' wall time limit separately from the cpu time limit. If one has a task with multiple concurrent solutions of which only one is actively computing something at any given time, then it seems quite likely that the default wall limit of 2*cpu_limit+1 is not enough. |
Isn't that also the case for other task types, i.e. communication? |
df9f99d to
819f3ea
Compare
I suppose so, but then this could be another way for Interactive to improve upon Communication :) |
819f3ea to
9c7c3de
Compare
No description provided.