fix: A11Y Improvement Content Display Screen Reader#4494
Draft
NathanZlion wants to merge 4 commits intomainfrom
Draft
fix: A11Y Improvement Content Display Screen Reader#4494NathanZlion wants to merge 4 commits intomainfrom
NathanZlion wants to merge 4 commits intomainfrom
Conversation
avinashbot
reviewed
May 7, 2026
| <div | ||
| ref={useMergeRefs(ref, dragHandleRefObject)} | ||
| role={ariaValue ? 'slider' : 'application'} | ||
| role={ariaValue ? 'slider' : 'button'} |
Member
There was a problem hiding this comment.
Is this the result of some accessibility feedback? If I recall correctly, role="application" is better for screen readers like NVDA/JAWS because it captures arrow key presses more reliably. Have you tested if wrapping the whole thing with role="application" solves this issue?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4494 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 933 933
Lines 29595 29596 +1
Branches 10757 10757
=======================================
+ Hits 28831 28832 +1
- Misses 716 757 +41
+ Partials 48 7 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve Screen Reader Experience for Colletion Preferences Content Display reordering.
Changes Done:
Related links, issue #, if available: n/a
Ticket: AWS-CXA-787
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.