Skip to content

feat: [WIP] navigation bar#4477

Draft
amanabiy wants to merge 1 commit intomainfrom
dev-v3-amanabiy-nav-first-stage
Draft

feat: [WIP] navigation bar#4477
amanabiy wants to merge 1 commit intomainfrom
dev-v3-amanabiy-nav-first-stage

Conversation

@amanabiy
Copy link
Copy Markdown
Member

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@amanabiy amanabiy changed the title Dev v3 amanabiy nav first stage [WIP] feat: navigation bar Apr 28, 2026
@amanabiy amanabiy changed the title [WIP] feat: navigation bar feat[WIP] : navigation bar Apr 28, 2026
@amanabiy amanabiy changed the title feat[WIP] : navigation bar feat: [WIP] navigation bar Apr 28, 2026
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-nav-first-stage branch from b372c2a to 131cf64 Compare April 29, 2026 06:37
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-nav-first-stage branch 2 times, most recently from 5d36456 to bd11547 Compare May 6, 2026 11:40
@amanabiy amanabiy requested a review from NathanZlion May 6, 2026 11:40
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-nav-first-stage branch 2 times, most recently from 77bf537 to 47a5d3f Compare May 6, 2026 15:50
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.41%. Comparing base (3417c05) to head (71b0688).

Files with missing lines Patch % Lines
src/test-utils/dom/navigation-bar/index.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4477      +/-   ##
==========================================
- Coverage   97.41%   97.41%   -0.01%     
==========================================
  Files         933      937       +4     
  Lines       29595    29627      +32     
  Branches    10757    10765       +8     
==========================================
+ Hits        28831    28861      +30     
- Misses        716      759      +43     
+ Partials       48        7      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanabiy amanabiy force-pushed the dev-v3-amanabiy-nav-first-stage branch from 5709454 to af6a719 Compare May 8, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant