Skip to content

chore: Add test id for scrolling into view#4432

Draft
NathanZlion wants to merge 2 commits intomainfrom
fix/Add-test-id-for-footer
Draft

chore: Add test id for scrolling into view#4432
NathanZlion wants to merge 2 commits intomainfrom
fix/Add-test-id-for-footer

Conversation

@NathanZlion
Copy link
Copy Markdown
Member

@NathanZlion NathanZlion commented Apr 13, 2026

Description

Add Test Id to use as selector for scrolling element into view in testing.

Fixing flaky integration test.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NathanZlion NathanZlion requested a review from a team as a code owner April 13, 2026 12:17
@NathanZlion NathanZlion requested review from pan-kot and removed request for a team April 13, 2026 12:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.39%. Comparing base (76aee69) to head (de71e8d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4432   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files         928      928           
  Lines       29224    29224           
  Branches    10571    10570    -1     
=======================================
  Hits        28462    28462           
- Misses        715      756   +41     
+ Partials       47        6   -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NathanZlion NathanZlion requested a review from amanabiy April 13, 2026 12:42
@NathanZlion NathanZlion enabled auto-merge April 13, 2026 13:13
@NathanZlion NathanZlion marked this pull request as draft April 15, 2026 14:14
auto-merge was automatically disabled April 15, 2026 14:14

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant