feat(heureka): add Mark Risk Accepted action to active vulnerabilities#1597
Open
feat(heureka): add Mark Risk Accepted action to active vulnerabilities#1597
Conversation
… mandatory - Add RiskAcceptanceModal mirroring FalsePositiveModal with an extra "Jira Ticket / Risk Acceptance Source Ticket" field - Add "Mark Risk Accepted" to the vulnerability popup menu alongside "Mark False Positive" - Make expiration date required in both modals with validation and inline error feedback
|
…agination, and add tests
…shes Remove manual encodeURIComponent() calls from navigate params in ImageDetails and ImageVersionsList — TanStack Router encodes params internally, so wrapping them again caused double-encoding (e.g. hashicorp/vault → hashicorp%252Fvault in the URL). Decode image and service params in the route loader before passing them to fetchImages and ImageDetails, following the same pattern already used in the route loader.
hodanoori
added
the
greenhouse-pr-preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Mark Risk Accepted" action to the active vulnerabilities tab in the service image details view. The new action mirrors the existing "Mark False Positive" flow and submits a
risk_acceptedremediation record. Expiration date is now mandatory in both actions.Changes Made
RiskAcceptanceModalcomponent with the same fields asFalsePositiveModalplus an optional Jira Ticket / Risk Acceptance Source Ticket field; the
ticket reference is prepended to the description on submit
menu alongside Mark False Positive, using
RemediationTypeValues.RiskAcceptedRiskAcceptanceModalandFalsePositiveModal, with inline validation and the confirm button disableduntil the field is set
RiskAcceptanceModalcovering rendering, disabled-statevalidation, confirm payload (including source ticket formatting), and cancel
behaviour
IssuesDataRowstests with a dedicated risk acceptance describe blockcovering active-tab visibility and revert scenarios
RemediatedIssuesDataRowstests with a risk acceptance revertdescribe block covering remediated-tab visibility and revert scenarios
Related Issues
Screenshots (if applicable)
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.