feature/cp-11581-db-support-for-enhanced-topic-selection-popup-configurable#351
Open
unnaticleverpush wants to merge 2 commits into
Open
Conversation
…urable Show a "Select All" / "Remove All" header above the topic checkbox list when `topicsDialogBulkActions` is enabled in the channel config.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4387820. Configure here.
There was a problem hiding this comment.
1 issue found across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Show a "Select All" / "Remove All" header above the topic checkbox list when
topicsDialogBulkActionsis enabled in the channel config.Note
Medium Risk
Changes subscription topic selection UI and bulk-toggle behavior; bugs could mis-sync selected topics before save, but scope is limited to the topics dialog.
Overview
When
topicsDialogBulkActionsis enabled in channel config, the topics dialog shows a Select All / Remove All row above the checkbox list. Buttons grey out when the action would do nothing and refresh as selections change.Bulk toggling snapshots topic checkboxes before updating them so listener-driven rebuilds of the list (including the unsubscribe “deselect all” path) do not cause crashes or wrong states (CP-11581).
confirmAlertSelectTopicsSaveTextcan override the positive button label; newselect_all/remove_allstrings were added for English and German.Reviewed by Cursor Bugbot for commit 32273dd. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Add a Select All / Remove All header to the topics dialog when
topicsDialogBulkActionsis enabled for quick bulk edits. Makes the enhanced topic selection popup configurable and safer (CP-11581).confirmAlertSelectTopicsSaveTextto override the Save label; added localizedselect_allandremove_allstrings (en/de).Written for commit 32273dd. Summary will update on new commits.
Review in cubic