Skip to content

feature/cp-11581-db-support-for-enhanced-topic-selection-popup-configurable#351

Open
unnaticleverpush wants to merge 2 commits into
masterfrom
feature/cp-11581-db-support-for-enhanced-topic-selection-popup-configurable
Open

feature/cp-11581-db-support-for-enhanced-topic-selection-popup-configurable#351
unnaticleverpush wants to merge 2 commits into
masterfrom
feature/cp-11581-db-support-for-enhanced-topic-selection-popup-configurable

Conversation

@unnaticleverpush
Copy link
Copy Markdown
Contributor

@unnaticleverpush unnaticleverpush commented May 27, 2026

Show a "Select All" / "Remove All" header above the topic checkbox list when topicsDialogBulkActions is enabled in the channel config.


Note

Medium Risk
Changes subscription topic selection UI and bulk-toggle behavior; bugs could mis-sync selected topics before save, but scope is limited to the topics dialog.

Overview
When topicsDialogBulkActions is enabled in channel config, the topics dialog shows a Select All / Remove All row above the checkbox list. Buttons grey out when the action would do nothing and refresh as selections change.

Bulk toggling snapshots topic checkboxes before updating them so listener-driven rebuilds of the list (including the unsubscribe “deselect all” path) do not cause crashes or wrong states (CP-11581).

confirmAlertSelectTopicsSaveText can override the positive button label; new select_all / remove_all strings were added for English and German.

Reviewed by Cursor Bugbot for commit 32273dd. Bugbot is set up for automated code reviews on this repo. Configure here.


Summary by cubic

Add a Select All / Remove All header to the topics dialog when topicsDialogBulkActions is enabled for quick bulk edits. Makes the enhanced topic selection popup configurable and safer (CP-11581).

  • New Features
    • Buttons auto-disable on no-ops and stay in sync as selections change; bulk actions snapshot checkboxes to avoid view rebuild issues and skip the unsubscribe box; disabled styling adapts to night mode.
    • Added confirmAlertSelectTopicsSaveText to override the Save label; added localized select_all and remove_all strings (en/de).

Written for commit 32273dd. Summary will update on new commits.

Review in cubic

…urable

Show a "Select All" / "Remove All" header above the topic checkbox list
when `topicsDialogBulkActions` is enabled in the channel config.
@unnaticleverpush unnaticleverpush self-assigned this May 27, 2026
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4387820. Configure here.

Comment thread cleverpush/src/main/java/com/cleverpush/CleverPush.java
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread cleverpush/src/main/java/com/cleverpush/CleverPush.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant