Skip to content

CFE-3866: Allowed select_region to converge across passes (3.27) #6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickanderson merged 6 commits into from
Apr 17, 2026
Merged

CFE-3866: Allowed select_region to converge across passes (3.27) #6076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fcf88e5
Tests: Removed outdated duplicate valgrind test
olehermanse Apr 16, 2026
fa9631a
valgrind.sh: Added metadata / instructions
olehermanse Apr 16, 2026
aa9376c
Updated plucked.cf.sub using make pluck
olehermanse Apr 16, 2026
d4eb73b
Removed duplicate definitions of lines_present bundle
olehermanse Apr 16, 2026
b103d21
Added test for select_region convergence across passes
nickanderson Apr 16, 2026
9ae3c7f
Enabled select_region to converge across multiple passes
nickanderson Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ jobs:
macos_unit_tests:
needs: unit_tests
uses: ./.github/workflows/macos_unit_tests.yml
valgrind_tests:
needs: unit_tests
uses: ./.github/workflows/valgrind.yml
static_check:
needs: unit_tests
uses: ./.github/workflows/job-static-check.yml
Expand Down
200 changes: 0 additions & 200 deletions .github/workflows/valgrind.sh
View file
Open in desktop

This file was deleted.

53 changes: 0 additions & 53 deletions .github/workflows/valgrind.yml
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions cf-agent/files_edit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,16 @@ typedef struct
char *changes_filename;
Item *file_start;
int num_edits;
int pass; // Current convergence pass (1 to CF_DONEPASSES-1)
#ifdef HAVE_LIBXML2
xmlDocPtr xmldoc;
#endif
NewLineMode new_line_mode;
} EditContext;

// Check if we're on the final convergence pass where errors should be reported
#define EDIT_CONTEXT_IS_FINAL_PASS(ec) ((ec)->pass >= CF_DONEPASSES - 1)

// filename must not be freed until FinishEditContext.
EditContext *NewEditContext(char *filename, const Attributes *a);
void FinishEditContext(EvalContext *ctx, EditContext *ec,
Expand Down
Loading
Loading