Skip to content

#902 friedland gl insurer claims data#905

Open
kennethshsu wants to merge 4 commits into
mainfrom
#902_-friedland_gl_insurer_claims_data
Open

#902 friedland gl insurer claims data#905
kennethshsu wants to merge 4 commits into
mainfrom
#902_-friedland_gl_insurer_claims_data

Conversation

@kennethshsu
Copy link
Copy Markdown
Collaborator

@kennethshsu kennethshsu commented Jun 2, 2026

Summary of Changes

Added another data friedland_gl_self_insurer.csv

Related GitHub Issue(s)

Closes #902

Additional Context for Reviewers

The data from the original ticket is actually not wrong. I think they are actually two separate datasets. The original dataset is named friedland_gl_insurer.csv used in the Freq/Sev chapter, but chapter 8 uses another data called friedland_gl_self_insurer.csv (with self in the filename). This PR adds the new dataset and does not modify the old dataset.

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Low Risk
Additive sample data and manifest metadata only; no changes to core library logic or security-sensitive paths.

Overview
Adds the friedland_gl_self_insurer bundled sample so it can be loaded via load_sample / list_samples, separate from the existing friedland_gl_insurer dataset.

Registers the sample in SAMPLES in _manifest.py (Accident Year / Calendar Year, Reported Claims and Paid Claims, cumulative) and ships friedland_gl_self_insurer.csv with 1998–2008 accident years valued at calendar year 2008.

Reviewed by Cursor Bugbot for commit d4a2e7d. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d4a2e7d. Configure here.

Comment thread chainladder/utils/data/friedland_gl_self_insurer.csv
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.92%. Comparing base (cbed23c) to head (d4a2e7d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #905   +/-   ##
=======================================
  Coverage   86.92%   86.92%           
=======================================
  Files          87       87           
  Lines        4942     4942           
  Branches      625      625           
=======================================
  Hits         4296     4296           
  Misses        456      456           
  Partials      190      190           
Flag Coverage Δ
unittests 86.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kennethshsu kennethshsu closed this Jun 2, 2026
@kennethshsu kennethshsu reopened this Jun 2, 2026
@kennethshsu kennethshsu self-assigned this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

friedland_gl_insurer missing data

1 participant