fix: suppress premature approval error while wallet is pending (#32)#232
Open
mkcash wants to merge 1 commit into
Open
fix: suppress premature approval error while wallet is pending (#32)#232mkcash wants to merge 1 commit into
mkcash wants to merge 1 commit into
Conversation
Bug: When user clicks 'Approve CAP' in Stake modal, the error handler fires before wallet (Metamask) confirmation completes, showing confusing error. Changes: - Don't call showError() for approval errors - Handle user-denied/rejected gracefully - Add isLoading state to approve button to prevent double-clicks Fixes capofficial#32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Problem
When user clicks "Approve CAP" in Stake modal, the error handler fired before wallet confirmation completes, showing a confusing error message.
Changes