Skip to content

Add pickling support for textparser.ParseError#3

Open
zariiii9003 wants to merge 2 commits into
cantools:masterfrom
zariiii9003:pickle-error
Open

Add pickling support for textparser.ParseError#3
zariiii9003 wants to merge 2 commits into
cantools:masterfrom
zariiii9003:pickle-error

Conversation

@zariiii9003
Copy link
Copy Markdown

@eerimoq i want to load a cantools database in a ProcessPoolExecutor, but the missing pickling support causes a BrokenProcessPool, if a parsing error occurs.

@andlaus
Copy link
Copy Markdown
Member

andlaus commented Jun 3, 2026

@eerimoq: any news here?

@andlaus
Copy link
Copy Markdown
Member

andlaus commented Jun 3, 2026

(if you want to get rid of maintenance for this module, we (the cantools maintainers) can take over and/or move it to the cantools github organization...)

@eerimoq
Copy link
Copy Markdown
Collaborator

eerimoq commented Jun 3, 2026

sounds like a plan

@eerimoq
Copy link
Copy Markdown
Collaborator

eerimoq commented Jun 3, 2026

juleq is maintainer on pypi and repo in cantools org now

@zariiii9003
Copy link
Copy Markdown
Author

juleq is maintainer on pypi and repo in cantools org now

Now that we have your attention, could you also add @andlaus to the cantools readthedocs admins? The documentation hasn't been updated in a while.

@eerimoq
Copy link
Copy Markdown
Collaborator

eerimoq commented Jun 3, 2026

what email should I add as maintainer?

@andlaus
Copy link
Copy Markdown
Member

andlaus commented Jun 4, 2026

the simplest approach would be to add @zariiii9003, @juleq and my account (@andlaus) to the collaborators with admin permissions of this repository. (that is if you want to keep it on your personal account. If you don't, you can change the ownership of the repo to the cantools github organization in the settings.)

@andlaus
Copy link
Copy Markdown
Member

andlaus commented Jun 4, 2026

juleq is maintainer on pypi and repo in cantools org now

oops, I did not grok that, forget my previous comment.

@zariiii9003: this looks good to me, can you merge?

@andlaus
Copy link
Copy Markdown
Member

andlaus commented Jun 4, 2026

what email should I add as maintainer?

you mean the author_email field in setup.py? I think it should be removed outright because we want people to open issues on github instead of sending emails to a random person...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants