Fix task side effects after direct file edits#1925
Open
martin-forge wants to merge 1 commit into
Open
Conversation
b5d527a to
f27af5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1921.
file-updatedemitter after lazy calendar service initialization.Related to #1696 and #1924. This PR is intentionally scoped to direct task-file reconciliation; moved-recurring exception support is separate.
Tests
npm test -- --runInBand tests/services/TaskCalendarSyncService.test.ts tests/unit/issues/issue-google-calendar-external-file-reconciliation.test.tsnpm run typechecknpm run lintnpm run buildvault-python 7 System/Scripts/vault/scan_public_pr.py --repo /Users/martin/Developer/tasknotes-main --base origin/main --head martin-forge/issue-1921-external-calendar-reconciliation-standalone