Modernize Puppeteer locator in BrowserStack SDK sample (Node · Puppeteer · Jest)#52
Open
AakashHotchandani wants to merge 4 commits into
Open
Modernize Puppeteer locator in BrowserStack SDK sample (Node · Puppeteer · Jest)#52AakashHotchandani wants to merge 4 commits into
AakashHotchandani wants to merge 4 commits into
Conversation
…ate) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Removes the postinstall `npm update browserstack-node-sdk` (supply-chain / install-time-execution vector that bypasses lockfile pinning). The browserstack-node-sdk `latest` dependency already resolves to the current SDK on `npm install`, so the postinstall was redundant. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ppeteer v22) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ium-webdriver) $x->::-p-xpath fixed (committed earlier). Adding selenium-webdriver avoids the preInitialize null check; puppeteer detection works on sdk latest. The SDK puppeteer-patcher launch flow still fails live (Puppeteer v22) — tracked for the Node SDK team alongside the Playwright findings. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the sample to the ::-p-xpath() locator (page.$x was removed in Puppeteer v22) and adds selenium-webdriver to satisfy preInitialize.
Live status: NOT yet green — the SDK puppeteer-patcher launch flow still fails on Puppeteer v22 (raised with the SDK team). Submitting the sample + fix for review.
Generated via the SDK sample-repo generator. Tracking: SDK-6221.