Skip to content

feat: consolidate deployment compose into root under --profile deploy (COW-976)#68

Open
lgahdl wants to merge 1 commit into
developfrom
luizhatem/cow-976-move-deployment-docker-compose-into-root-as-a-profile-deploy
Open

feat: consolidate deployment compose into root under --profile deploy (COW-976)#68
lgahdl wants to merge 1 commit into
developfrom
luizhatem/cow-976-move-deployment-docker-compose-into-root-as-a-profile-deploy

Conversation

@lgahdl
Copy link
Copy Markdown
Contributor

@lgahdl lgahdl commented May 28, 2026

Summary

Consolidate deployment/docker-compose.yml into the root docker-compose.yml as a --profile deploy profile, eliminating the duplicate file. The default docker compose up dev-database behavior is unchanged.

Changes

  • Added postgres-deploy and ponder services to root docker-compose.yml under profiles: [deploy]
  • Adjusted volume path for start-db.sh from ./static/ to ./deployment/static/ (context is now repo root)
  • Deleted deployment/docker-compose.yml
  • Updated deployment/manage.sh to reference ../docker-compose.yml with --profile deploy
  • Updated references to the old file path in docs/deployment.md

How to Test

  1. Run docker compose --profile deploy up and verify the deploy stack starts (postgres + ponder)
  2. Run docker compose up (no profile) and verify only the dev postgres starts as before

Checklist

  • Tests pass locally
  • Linting passes
  • Documentation updated (if needed)
  • Breaking changes documented (if any)

Breaking Changes

None — docker compose --profile deploy up replaces the old docker compose -f deployment/docker-compose.yml up.

Related Issues

COW-976

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 28, 2026

COW-976

@lgahdl lgahdl changed the title Luizhatem/cow 976 move deployment docker compose into root as a profile deploy feat: consolidate deployment compose into root under --profile deploy (COW-976) May 28, 2026
Comment thread docker-compose.yml
Comment thread docker-compose.yml Outdated
timeout: 5s
retries: 5

postgres-deploy:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we can't use the same db container config for prod and dev?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point — addressed in the latest commit. The two services are now unified into a single postgres service that uses ${POSTGRES_USER:-postgres}-style defaults, so docker compose up works for dev without a .env file, and production overrides the credentials via env vars.

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented May 28, 2026

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

… (COW-976)

Moves deployment/docker-compose.yml to the root docker-compose.yml,
unifying dev and prod postgres into a single service. Production containers
run under the "deploy" profile. Updates manage.ts and deployment docs
accordingly. Default postgres credentials are env-var-substituted dev
fallbacks, not real secrets.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@lgahdl lgahdl force-pushed the luizhatem/cow-976-move-deployment-docker-compose-into-root-as-a-profile-deploy branch from 8131e6d to b7f3b58 Compare May 29, 2026 13:18
@lgahdl lgahdl requested a review from yvesfracari May 29, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants