chore(execution): Refactor & Test Discovery Services#2341
Open
chore(execution): Refactor & Test Discovery Services#2341
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
🟡 Heimdall Review Status
|
refcell
force-pushed
the
rf/fix/bootnode-discv5-enr-port
branch
from
3dab16f to
1ebf037
Compare
refcell
changed the title
refcell
force-pushed
the
rf/fix/bootnode-discv5-enr-port
branch
2 times, most recently
from
78edbc9 to
43af5d0
Compare
Set the discv5 UDP listen port explicitly via ListenConfig instead of relying on the DEFAULT_DISCOVERY_V5_PORT constant, so the port in the ENR always matches --v5-addr. Extracts discv4_config() and discv5_config() methods to make the port wiring testable, and adds rstest parametrized tests that assert discv5_config().discovery_socket().port() == v5_addr.port().
refcell
force-pushed
the
rf/fix/bootnode-discv5-enr-port
branch
from
a80eaac to
ba70349
Compare
Contributor
Review SummaryClean refactor. The previous revision's issues (passing What changed: Extracted One minor observation (not blocking):
No other correctness, safety, or performance concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#2339 fixed this isue where the discv5 ENR was being stamped with the discv4 port (
v4_addr.port()) instead of the discv5 listen port (v5_addr.port()), making the node unreachable via discv5.This PR refactors the config construction and adds a bunch of unit testing to ensure ports and addresses across the discovery services are consistent and reachable.