Add a document about rounding#334
Open
EndymionJkb wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
joaobrunoah
approved these changes
May 28, 2026
Member
joaobrunoah
left a comment
joaobrunoah
left a comment
There was a problem hiding this comment.
LGTM! One small comment only
| |-----------|----------| | ||
| | Swap, given an exact amount in | the amount out is rounded **down**: you receive the same or slightly less | | ||
| | Swap, given an exact amount out | the amount in is rounded **up**: you pay the same or slightly more | | ||
| | Add liquidity, receiving BPT | the BPT minted is rounded **down** | |
Member
There was a problem hiding this comment.
Suggested change
| | Add liquidity, receiving BPT | the BPT minted is rounded **down** | | |
| | Add liquidity given exact amounts in, receiving BPT | the BPT minted is rounded **down** | |
Both add liquidity operations receive BPTs, so I'd say that you need to specify amounts in to round BPT minted down.
Same applies to remove liquidity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the rounding conventions of V3, and how, in contrast to V2, the Vault now controls scaling, rates, and the rounding direction.
Closes #168