Skip to content

Fix YARD comment with extra space#637

Merged
arpit-jn merged 3 commits into
auth0:masterfrom
qtro:fix-yard-comment
May 29, 2026
Merged

Fix YARD comment with extra space#637
arpit-jn merged 3 commits into
auth0:masterfrom
qtro:fix-yard-comment

Conversation

@qtro
Copy link
Copy Markdown
Contributor

@qtro qtro commented Jan 6, 2025

Changes

Fix YARD comments with extra space.

References

I saw this module and I found it.

Testing

It isn't necessary to test cuz fix only doc.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of Ruby

Checklist

@qtro qtro requested a review from a team as a code owner January 6, 2025 05:46
arpit-jn
arpit-jn previously approved these changes May 8, 2026
@arpit-jn
Copy link
Copy Markdown
Contributor

arpit-jn commented May 8, 2026

Hi @qtro , apologies for the long delay in getting back to you on this. It slipped through the cracks and that's on us.

The fix looks great and we'd like to get it merged. One thing blocking: the commit isn't signed. Could you either:

  • Sign your commit and force-push, or
  • Let us know if you're okay with us cherry-picking this on your behalf (you'll remain as the author)?

Thanks for the contribution and your patience.

@qtro
Copy link
Copy Markdown
Contributor Author

qtro commented May 15, 2026

Hi @arpit-jn
Thanks for getting back to me, no worries about the timing! I've signed the commit and force-pushed. Should be good to merge now 👍

@qtro qtro requested a review from arpit-jn May 18, 2026 01:16
Copy link
Copy Markdown
Contributor

@arpit-jn arpit-jn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpit-jn arpit-jn merged commit 3ff2a3f into auth0:master May 29, 2026
10 of 11 checks passed
@arpit-jn arpit-jn mentioned this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants