fix(component): honor image pull policy for kbagent#10253
Open
weicao wants to merge 1 commit into
Open
Conversation
Collaborator
|
Auto Cherry-pick Instructions |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10253 +/- ##
==========================================
+ Coverage 52.42% 52.49% +0.06%
==========================================
Files 533 533
Lines 61230 61237 +7
==========================================
+ Hits 32099 32144 +45
+ Misses 25872 25837 -35
+ Partials 3259 3256 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KUBEBLOCKS_IMAGE_PULL_POLICYIfNotPresentwhen the config is emptyScope
This only changes the component controller kbagent injection path. Existing DataProtection, custom Ops, and other job paths that already read
KBImagePullPolicyare unchanged.The empty-config fallback to
IfNotPresentis deliberate backward compatibility with the previous hardcoded component kbagent behavior. It differs from some job paths that leave an empty pull policy for Kubernetes defaults, but avoids changing component kbagent behavior whenKUBEBLOCKS_IMAGE_PULL_POLICYis not set.Validation
go test ./pkg/controller/component -run TestBuildKBAgentContainerUsesConfiguredImagePullPolicy -count=1go test -c ./pkg/controller/componentgit diff --checkLocal Ginkgo/envtest execution is not counted as passed because this machine is missing
/usr/local/kubebuilder/bin/etcd; CI should provide that coverage.Context
MariaDB T6 validation hit a repeated kbagent tools image tag-alias trap while the KubeBlocks deployment had
KUBEBLOCKS_IMAGE_PULL_POLICY=Never. The controller component path still injected kbagent with hardcodedIfNotPresent, so pod image resolution could re-enter the registry path.