fix: Add validation for componentInfos in OpsDefinition controller#10155
Open
destinyoooo wants to merge 2 commits into
Open
fix: Add validation for componentInfos in OpsDefinition controller#10155destinyoooo wants to merge 2 commits into
destinyoooo wants to merge 2 commits into
Conversation
Collaborator
|
Auto Cherry-pick Instructions |
wangyelei
reviewed
Apr 22, 2026
apecloud-bot
added
pre-approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds comprehensive validation logic to the OpsDefinition controller to verify the
componentInfosfield before marking an OpsDefinition as Available. Previously, the controller had a TODO comment indicating that validation for serviceKind, connectionCredentialName, and serviceName was missing, which could lead to OpsDefinitions being marked as Available even with invalid or non-existent references.