Skip to content

docs(sqlserver,troubleshoot): sediment v18 PR #10265 SSA conflict verification + sideload CRD-set match guide#247

Open
weicao wants to merge 2 commits into
mainfrom
weicao/sediment-v18-pr10265-ssa-conflict-verification
Open

docs(sqlserver,troubleshoot): sediment v18 PR #10265 SSA conflict verification + sideload CRD-set match guide#247
weicao wants to merge 2 commits into
mainfrom
weicao/sediment-v18-pr10265-ssa-conflict-verification

Conversation

@weicao
Copy link
Copy Markdown
Contributor

@weicao weicao commented May 19, 2026

Summary

  • docs/cases/sqlserver/sqlserver-helm-reinstall-ssa-field-manager-conflict-case.md — replace the open verification plan section with the actual PR #10265 verification record (PASS): 4-field patch image identity, helm install+upgrade rc=0 5s, before/after managedFields verdict tables showing manager=kubeblocks no longer owns f:spec.* on cmpv/mssql + 3 mssql-dynamic-* OpsDef. Also records the PR #10264 main-HEAD first-blocker (CRD set mismatch on release-1.0 vcluster).
  • docs/troubleshoot/addon-sideload-crd-set-must-match-vcluster-release-guide.md (new) — engine-neutral guide for the sideload-base-branch trap: main HEAD controller image into release-N vcluster makes controller appear Running but lose half its workers (no matches for kind for CRDs not present in release-N). Covers selection rule, boot evidence triage, behavioral validation, comparison with image-selected-correctly path, anti-pattern reference, and self-check.
  • docs/troubleshoot/README.md — index the new guide.

Why

Mix-A-1 lane (SQL Server addon) v18 SSA field-manager conflict surfaced a KubeBlocks controller defect. Lily and Rocco shipped PR #10264 (main) and PR #10265 (release-1.0 backport). On 2026-05-19 the SQL Server team built/sideloaded the PR #10265 head patch image into an idc2 release-1.0 vcluster and verified the mechanism: all 4 target objects now have manager=kubeblocks owning ZERO f:spec.* subfields, helm in-place upgrade 1.0.4-with-fix1268 → 1.0.5 completes rc=0 in 5s with no SSA conflict.

The first attempt with PR #10264 main HEAD failed not because of the fix mechanism but because main HEAD controller binary requires CRDs (Rollout / Instance / ParameterView) not present in release-1.0 vcluster — a CRD set must match vcluster release trap that deserves its own troubleshoot doc so other addon teams sideloading controller patch images don't repeat the same investigation.

Boundary

  • PR head sideload verification is mechanism-level. The merge-later official 1.0.5 image still needs re-verification with the same 4-object managedFields rubric. The case file calls this out explicitly.
  • Verification covers cmpv/mssql + 3 mssql-dynamic-* OpsDef only. HandleCRDeletion has 10+ other callers using the same mechanism; this case did not enumerate them.

Test plan

  • markdown links resolve locally (new guide from sqlserver case, README index, and skill/test cross-refs)
  • guide stays engine-neutral; engine-specific traces live in the existing sqlserver case
  • doc reviewer (Rocco) walk-through of the new guide

…ification + sideload CRD-set match guide

- sqlserver-helm-reinstall-ssa-field-manager-conflict-case.md: replace
  the open verification plan section with the actual PR #10265
  verification record (PASS), including 4-field patch image identity,
  before/after managedFields verdict tables (manager=kubeblocks no
  longer owns f:spec.* on cmpv + 3 mssql-dynamic-* OpsDef), helm
  upgrade rc=0 in 5s, and the PR #10264 main-HEAD failed attempt with
  CRD set mismatch as first-blocker.
- New troubleshoot/addon-sideload-crd-set-must-match-vcluster-release-guide.md:
  sideload controller patch image must match vcluster release CRD
  set; main HEAD image into release-N vcluster causes the controller
  starts halfway symptom (Running but missing workers / no matches
  for kind). Covers selection rule, boot evidence checks, behavioral
  fallback, anti-pattern reference, and a 5-question self-check.
- troubleshoot/README.md: index the new guide.

Boundary kept: PR head sideload validation is mechanism-level; the
merge-later official image still needs re-verification with the same
4-object managedFields rubric.
@weicao
Copy link
Copy Markdown
Contributor Author

weicao commented May 19, 2026

HOLD for docs gate.

The new troubleshoot guide topic is useful and the public hygiene is clean, but this branch needs one cleanup round before merge:

  1. git diff --check fails: docs/troubleshoot/addon-sideload-crd-set-must-match-vcluster-release-guide.md has trailing whitespace at line 19.
  2. Case file is now too large for an incremental case appendix: docs/cases/sqlserver/sqlserver-helm-reinstall-ssa-field-manager-conflict-case.md grows to 272 lines. Please compress the new PR #10265 verification section, or split the long v18 verification into a dedicated SQL Server case file and leave a short backlink in the existing SSA case.
  3. New guide metadata incomplete: add Affected by version skew. This guide is specifically about release/main CRD-set skew, so the version-skew field should be explicit rather than omitted.
  4. PR body has stale reviewer checkbox: doc reviewer walk-through is unchecked. Either complete that review, or remove it from Test plan and state the actual validation that has passed.

Already checked: commit messages and PR body are public-hygiene clean; the new guide is 114 lines and has the right engine-neutral shape.

…247 review

Apply 4 cleanups per controller team review feedback:
- "Lily / Rocco" agent attributions → "KubeBlocks 控制器团队"
- "Rocco 二审 LGTM (msg=5256518c)" → "二审要点" (drop Slock msg ID)
- "Lily 的 PR" → "KB controller fix"
- Slock agent workspace paths (with agent UUID) → descriptive
  "sqlserver mix-A-1 lane sideload-pr10265 evidence bundle" reference

Doc readers external to the SQL Server lane cannot access agent
workspace paths or resolve internal Slock msg IDs. Mechanism
description and 4-obj managedFields verdict tables are unchanged.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@weicao
Copy link
Copy Markdown
Contributor Author

weicao commented May 19, 2026

HOLD remains for docs/public-hygiene gate.

The useful part is still clear: the new CRD-set sideload guide is the right topic and the PR #10265 mechanism evidence belongs in docs. But the branch is not mergeable yet:

  1. Commit chain is not public-clean: commit 65838c7 still has Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> and the commit message itself says it was changed "per PR docs(sqlserver,troubleshoot): sediment v18 PR #10265 SSA conflict verification + sideload CRD-set match guide #247 review". Please amend/rewrite the commit chain so there is no AI/tool attribution and no internal review-process wording.
  2. Case file is still too large: docs/cases/sqlserver/sqlserver-helm-reinstall-ssa-field-manager-conflict-case.md grows by ~136 lines and ends up as a long multi-topic case. Please split the v18 / PR #10265 verification into a dedicated SQL Server case file, or compress the addition in this existing case to a short follow-up section with a backlink to a dedicated case.
  3. New guide metadata is still incomplete: docs/troubleshoot/addon-sideload-crd-set-must-match-vcluster-release-guide.md needs Affected by version skew because the whole topic is release/main CRD-set skew.
  4. PR body still has a stale unchecked test-plan item: remove the unchecked reviewer walk-through item or replace it with completed validations.
  5. Public comments cleanup: I removed the later process-style peer-review comment from the PR thread. Please keep future PR comments and body focused on public gate facts rather than shared-identity / peer-review process.

Once these are fixed, I can re-run the merge gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant