[ZEPPELIN-6312] Remove configuration WS usage in frontend#5060
Open
seung-00 wants to merge 1 commit intoapache:masterfrom
Open
[ZEPPELIN-6312] Remove configuration WS usage in frontend#5060seung-00 wants to merge 1 commit intoapache:masterfrom
seung-00 wants to merge 1 commit intoapache:masterfrom
Conversation
seung-00
force-pushed
the
feature/ZEPPELIN-6312
branch
4 times, most recently
from
f35d4eb to
4c00dde
Compare
tbonelee
requested changes
Sep 2, 2025
Contributor
tbonelee
left a comment
tbonelee
left a comment
There was a problem hiding this comment.
Replacing WS with REST API seems reasonable since it reduce complexity.
As the login page is currently not working properly, that issue should be fixed as well.
seung-00
force-pushed
the
feature/ZEPPELIN-6312
branch
from
4c00dde to
325c067
Compare
Contributor
Author
|
I’ve updated according to the review comments. Removing WS right now would break things, so I’ll fix this in another PR before merging this one. |
Contributor
Could you also take a look at this? It seems that fetching configurations in `ConfigurationService.initialize()` when the user is not logged in might be causing some issues.
|
1 task
tbonelee
pushed a commit
that referenced
this pull request
Jan 22, 2026
…REST API ### What is this PR for? Currently, configuration data is fetched through both REST API and WebSocket channels. However, the WebSocket path does not perform permission checks, and the only required data from it is the WebSocket max message size. I extracted the websocket max message size field into a dedicated REST API, to improve security and simplify configuration handling. ### What type of PR is it? Improvement ### Todos * [ ] #5060 ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/6366 ### How should this be tested? - Check the configuration page (/configuration) - Check the notebook page (/notebook/{notebook_id}) ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? N * Is there breaking changes for older versions? Y * Does this needs documentation? N Closes #5099 from seung-00/feature/ZEPPELIN-6366. Signed-off-by: ChanHo Lee <chanholee@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR removes usage of the configuration API via WebSocket in the frontend.
The configuration API exists in both WS and REST, but unlike other APIs, it doesn’t seem to need two separate channels.
Maintaining both surfaces increases maintenance cost, so this PR unifies them by keeping only the REST API.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: