sim/camera: add AVFoundation backend and multi-cam support#18745
Open
PeterBee97 wants to merge 6 commits intoapache:masterfrom
Open
sim/camera: add AVFoundation backend and multi-cam support#18745PeterBee97 wants to merge 6 commits intoapache:masterfrom
PeterBee97 wants to merge 6 commits intoapache:masterfrom
Conversation
PeterBee97
requested review from
Donny9,
jerpelea,
masayuki2009,
pkarashchenko,
xiaoxiang781216 and
yamt
as code owners
github-actions
Bot
added
Area: Build system
Arch: simulator
anchao
previously approved these changes
Apr 15, 2026
acassis
requested changes
Apr 15, 2026
Contributor
acassis
left a comment
acassis
left a comment
There was a problem hiding this comment.
@PeterBee97 WOW! Amazing! Please update the nxcamera Documentation/ to include this new parameter: https://nuttx.apache.org/docs/latest/applications/system/nxcamera/index.html
Contributor
|
@PeterBee97 please include this picture in the Documentation page, it is funny :-) |
simbit18
previously approved these changes
Apr 15, 2026
PeterBee97
force-pushed
the
avfoundation
branch
from
d0fdb9c to
1131750
Compare
Contributor
Author
As u wish :) |
PeterBee97
force-pushed
the
avfoundation
branch
from
1131750 to
f1c856b
Compare
simbit18
previously approved these changes
Apr 16, 2026
acassis
previously approved these changes
Apr 16, 2026
Contributor
acassis
left a comment
acassis
left a comment
There was a problem hiding this comment.
@PeterBee97 Amazing! Thank you very much!
PeterBee97
force-pushed
the
avfoundation
branch
from
f1c856b to
c2ea6da
Compare
Contributor
|
Hi @PeterBee97 please fix |
PeterBee97
force-pushed
the
avfoundation
branch
2 times, most recently
from
6b24b6b to
6ae23c9
Compare
Add dummy.c so video can build an archive even when there are no other objects (e.g. on macOS). Signed-off-by: bijunda <bijunda@bytedance.com>
PeterBee97
force-pushed
the
avfoundation
branch
from
6ae23c9 to
c07e073
Compare
PeterBee97
force-pushed
the
avfoundation
branch
from
c07e073 to
18260b8
Compare
added 5 commits
April 27, 2026 20:40
Move common v4l2 capture framework changes to a standalone commit. Signed-off-by: bijunda <bijunda@bytedance.com>
Allow the SIM camera/V4L2 capture framework to manage multiple imgdata instances with dynamic mounting. This avoids cross-talk between camera streams when multiple devices are used. Signed-off-by: Peter Bee <bijunda@bytedance.com>
Adapt the macOS AVFoundation backend for multi-device discovery, camera index mapping and capture startup compatibility. This enables reliable use of multiple cameras through the SIM camera framework. Signed-off-by: Peter Bee <bijunda@bytedance.com>
/Library/Developer/CommandLineTools/usr/bin/c++filt: error: unknown argument '-[' Signed-off-by: Peter Bee <bijunda@bytedance.com>
Document the nxcamera command usage, including device selection, resolution, and pixel format options. Also mention recent support for multi-instance camera mounting and the macOS AVFoundation backend on the SIM platform. Signed-off-by: Peter Bee <bijunda@bytedance.com>
PeterBee97
force-pushed
the
avfoundation
branch
from
18260b8 to
bd705d1
Compare
acassis
approved these changes
Apr 27, 2026
jerpelea
approved these changes
Apr 27, 2026
| FAR struct imgdata_s *imgdata; | ||
| FAR struct imgsensor_s *imgsensor; | ||
| enum v4l2_scene_mode capture_scene_mode; | ||
| uint8_t open_num; |
| get_connected_imgsensor(FAR struct imgsensor_s **sensors, | ||
| size_t sensor_num) | ||
| { | ||
| FAR struct imgsensor_s *sensor = NULL; |
| return ret; | ||
| } | ||
|
|
||
| g_capture_registered_data[index].devpath = registered_devpath; |
Contributor
There was a problem hiding this comment.
why do you need save devpath
| priv->sensor.ops = &g_sim_camera_ops; | ||
| priv->sensor.frmsizes_num = 1; | ||
| priv->sensor.frmsizes = g_frmsizes; | ||
| priv->sensors[0] = sensor; |
Contributor
There was a problem hiding this comment.
why do you need add sensors field
|
|
||
| wd_start(&priv->wdog, 0, sim_camera_interrupt, (wdparm_t)priv); | ||
| return 0; | ||
| g_sim_camera_privs = kmm_zalloc(sizeof(sim_camera_priv_t) * (size_t)count); |
| static void sim_camera_interrupt(wdparm_t arg) | ||
| { | ||
| sim_camera_priv_t *priv = (sim_camera_priv_t *)arg; | ||
| struct timespec ts; |
Contributor
There was a problem hiding this comment.
why change? don't add the unnecessary change into pr, which just make your change review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add AVFoundation backend and multi-cam support, enabling macOS users as well as Linux users to use multiple cameras on Simulator.
Impact
mkallsymshost-tool behavior for Objective-C symbols on macOSTesting
Tested on:
sim:nxcamera