Fix default name evaluation for CDI beans#9350
Open
NicolaIsotta wants to merge 1 commit intoapache:masterfrom
Open
Fix default name evaluation for CDI beans#9350NicolaIsotta wants to merge 1 commit intoapache:masterfrom
NicolaIsotta wants to merge 1 commit intoapache:masterfrom
Conversation
according to the specs, the first char must always be lowercased
490471f to
c0f9db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the evaluation of the default name for CDI beans to strictly align with the CDI specifications.
Quoting CDI 1.1 specs:
Subsequent specifications all maintain the exact same text. Here is the latest: Jakarta EE CDI 4.1.
Historical Notes
I'm not exactly sure why the behavior was originally changed. My guess is that some implementations weren't perfectly aligned with the specifications at the time. For historical context on the deviation, see:
NB: this currently targets master, but it would be nice to have this in NB30
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)