Implement InsertTabletsWithCtx for tablet insertion#156
Implement InsertTabletsWithCtx for tablet insertion#156hchw wants to merge 1 commit intoapache:mainfrom
Conversation
Add InsertTabletsWithCtx method to insert multiple tablets with context support.
|
Any motivation to add this function? |
To add a timeout to data writes, preventing function handles from being released because of write timeouts. |
|
Why don't the functions you provide come with timeout control parameters? |
|
Thanks for the PR. I think the motivation is valid: the current That said, this looks like a partial API fix rather than a complete one. Other write methods such as One more detail worth documenting: this timeout would be a client-side RPC context timeout/cancellation. It lets the caller stop waiting and release client-side resources, but it does not necessarily guarantee that a request already received by the server is aborted server-side. |
Add InsertTabletsWithCtx method to insert multiple tablets with context support.