feat(consensus): cache reply payload and notify subscriber on commit#3223
Open
krishvishal wants to merge 3 commits intoapache:masterfrom
Open
feat(consensus): cache reply payload and notify subscriber on commit#3223krishvishal wants to merge 3 commits intoapache:masterfrom
krishvishal wants to merge 3 commits intoapache:masterfrom
Conversation
3dac3e9 to
ff31ebd
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3223 +/- ##
============================================
- Coverage 74.48% 74.47% -0.01%
Complexity 943 943
============================================
Files 1188 1192 +4
Lines 106530 107619 +1089
Branches 83560 84666 +1106
============================================
+ Hits 79350 80154 +804
- Misses 24433 24679 +246
- Partials 2747 2786 +39
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientTable(CachedReply, refcountedFrozenbuffer, Arc-bump on dedup) and deliver them to in-process subscribers via a oneshot channel embedded inPipelineEntry. Replaces the priorNotify/pending-map indirection; awaiters no longer need a separate cache lookup after wakeup.ClientTableis metadata-only. Partition plane is at-least-once; consumers handle duplicates.EvictionHeader/EvictionReasonwire frame; typed reasons let the SDK trigger its eviction callback.prepare_queue(cap 8) plus a bufferedrequest_queue(cap 64).is_full()reports only the prepare queue so admission stays separate from drop-on-full backpressure. View-change reset cancels subscribers and clears the request queue; the prepare queue survives for DVC reconciliation.