fix(connectors): unify extract_column_value into single free function#3199
fix(connectors): unify extract_column_value into single free function#3199atharvalade wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3199 +/- ##
=============================================
- Coverage 74.10% 19.21% -54.89%
Complexity 943 943
=============================================
Files 1159 1157 -2
Lines 102033 90323 -11710
Branches 79083 67391 -11692
=============================================
- Hits 75607 17356 -58251
- Misses 23765 72553 +48788
+ Partials 2661 414 -2247
🚀 New features to boost your workflow:
|
022bacc to
6a3e441
Compare
6a3e441 to
08153c5
Compare
|
@atharvalade Also remeber about #3196 where you also add Date |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR. Thank you for your contribution! |
Which issue does this PR close?
Closes #3172
Rationale
Bug fixes or new type support added to one copy of
extract_column_valuesilently won't apply to the other, causing divergence between sequential and parallel code paths.What changed?
The Postgres source connector had
extract_column_valueas a method onPostgresSource(&self), making it impossible to call from static/parallel contexts without duplicating the function. Any future parallel/chunked path would need its own copy.Converted it to a single free function callable from any context. Added missing
DATE(viachrono::NaiveDate) andBPCHARtype handling that the parallel copy on the benchmark branch had but this version lacked.Local Execution
AI Usage