Skip to content

feat(rest): support storage-credentials in PlanCompleted response #3235

Open
tanmayrauth wants to merge 1 commit intoapache:mainfrom
tanmayrauth:support-storage-credentials-irc-responses
Open

feat(rest): support storage-credentials in PlanCompleted response #3235
tanmayrauth wants to merge 1 commit intoapache:mainfrom
tanmayrauth:support-storage-credentials-irc-responses

Conversation

@tanmayrauth
Copy link
Copy Markdown

@tanmayrauth tanmayrauth commented Apr 13, 2026

Adds storage-credentials support for CompletedPlanningResult (PlanCompleted). LoadCredentialsResponse support is pending.

Fixes: #3165

Rationale for this change

Are these changes tested? Yes

Are there any user-facing changes? No

…rtial fix for apache#3165)

Adds storage-credentials support for CompletedPlanningResult (PlanCompleted).
LoadCredentialsResponse support is pending.
@tanmayrauth tanmayrauth force-pushed the support-storage-credentials-irc-responses branch from ddd2380 to cd844d3 Compare April 13, 2026 21:51
@geruh geruh self-requested a review April 15, 2026 03:21
@tanmayrauth
Copy link
Copy Markdown
Author

@kevinjqliu @Fokko can you please review and approve this?

Copy link
Copy Markdown
Member

@geruh geruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this open intentionally because there are deeper design decisions that needed to get sorted out before we figure out a path forward.

The issue is that today there's tight coupling between FileIO and the objects that hold it like Table, the distinction between REST ops and base ops. FileIO gets set once at construction and everything downstream assumes it stays fixed. TOday that works fine for load_table and all current interactions.

But for scan planning, credentials arrive after table creation so what happens to the FileIO that was already wired up? Overwriting it will break other operations that still hold a reference to the original IO. I think this is a bigger change, and to give confidence in the path forward we should map out the relationship of FileIO and Table how it's used. So that when we eventually need something like a prefixed FileIO client, it's a simple change.

I think that would be a good start and take a look at the RESTTableScan and the sequence of operations there, and then we could figure out a more pythonic equivalent would look like. Happy to discuss more!

@tanmayrauth
Copy link
Copy Markdown
Author

@geruh Thanks for the review! Happy to dig into the FileIO/Table relationship and map out how it's used before we finalize the approach. Will take a look at RESTTableScan and the sequence of operations and follow up with a more detailed design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support storage-credentials in other IRC responses

2 participants