Skip to content

HBASE-30063 Upgrade hbase-server to use junit5 Part7#8113

Open
liuxiaocs7 wants to merge 3 commits intoapache:branch-2from
liuxiaocs7:HBASE-30063-branch-2
Open

HBASE-30063 Upgrade hbase-server to use junit5 Part7#8113
liuxiaocs7 wants to merge 3 commits intoapache:branch-2from
liuxiaocs7:HBASE-30063-branch-2

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 added the backport This PR is a back port of some issue or issues already committed to master label Apr 22, 2026
@liuxiaocs7 liuxiaocs7 requested a review from Copilot April 22, 2026 14:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the branch-2 JUnit migration for hbase-server master-related tests (HBASE-30063, Part 7), converting JUnit4-style tests to JUnit Jupiter and aligning with the project’s JUnit5 tagging/parameterization patterns.

Changes:

  • Migrates many master tests from JUnit4 (@Before/@After/@Category/@RunWith, org.junit.Assert) to JUnit5 (@BeforeEach/@AfterEach/@Tag, org.junit.jupiter.api.Assertions).
  • Converts selected patterns like parameterized tests and cluster lifecycle rules to JUnit5 equivalents (e.g., @HBaseParameterizedTestTemplate, MiniClusterExtension).
  • Refactors the MasterRegionMutation tests by extracting shared logic into a new AbstractTestMasterRegionMutation base class.

Reviewed changes

Copilot reviewed 78 out of 78 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestWarmupRegion.java JUnit5 annotations/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestUnknownServers.java JUnit5 annotations/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java JUnit5 annotations/assertions + tags; assertion message arg order updated in one place.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitRegionWhileRSCrash.java JUnit5 annotations/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java JUnit5 annotations/assertions + tags; minor assertion API usage changes.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestShutdownWithNoRegionServer.java JUnit5 annotations + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestShutdownBackupMaster.java JUnit5 annotations/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestServerCrashProcedureStuck.java JUnit5 annotations + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestServerCrashProcedureCarryingMetaStuck.java JUnit5 annotations + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRoundRobinAssignmentOnRestartSplitWithoutZk.java JUnit5 tags (inherits behavior).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRoundRobinAssignmentOnRestart.java JUnit5 annotations/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java Migrates JUnit4 parameterized test to @HBaseParameterizedTestTemplate + JUnit5 lifecycle.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRetainAssignmentOnRestartSplitWithoutZk.java JUnit5 tags (inherits behavior).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRetainAssignmentOnRestart.java JUnit5 annotations/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRestartWithEmptyWALDirectory.java JUnit5 annotations/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionsRecoveryConfigManager.java JUnit5 lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionsRecoveryChore.java JUnit5 lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionState.java JUnit5 assertions + tags; removes JUnit4 TestName.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlansWithThrottle.java JUnit5 annotations/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement2.java JUnit5 lifecycle + tags; uses TestInfo for per-test naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java JUnit5 lifecycle/assertions + tags; replaces @Ignore with @Disabled.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRecreateCluster.java JUnit5 lifecycle/assertions + tags; removes JUnit4 TestName.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOldWALsDirSizeChore.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestNewStartedRegionServerVersion.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMigrateAndMirrorMetaLocations.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMetaShutdownHandler.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMetaAssignmentWithStopMaster.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMergeTableRegionsWhileRSCrash.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterUseIp.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterTransitions.java JUnit5 lifecycle/assertions + tags; replaces @Ignore with @Disabled.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java JUnit5 lifecycle/assertions + tags; uses TestInfo for per-test naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterRepairMode.java JUnit5 lifecycle/assertions + tags; uses TestInfo for per-test naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterRegionMutation2.java Migrates to JUnit5 and refactors to shared abstract base.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterRegionMutation1.java Migrates to JUnit5 and refactors to shared abstract base.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterQosFunction.java JUnit5 lifecycle + tags; updates priority function instantiation.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java JUnit5 lifecycle/assertions + tags; uses TestInfo for per-test naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java JUnit5 lifecycle/assertions + tags; replaces @Ignore with @Disabled.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetricsWrapper.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetrics.java JUnit5 lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterHandlerFullWhenTransitRegion.java JUnit5 @BeforeAll + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFileSystemWithWALDir.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFileSystemWithStoreFileTracking.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFileSystem.java JUnit5 lifecycle/assertions + tags; uses TestInfo for per-test naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailoverBalancerPersistence.java JUnit5 assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java JUnit5 lifecycle/assertions + tags; uses TestInfo for per-test naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterDryRunBalancer.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterCoprocessorServices.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterChoreScheduled.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterBalancerNPE.java JUnit5 lifecycle/assertions + tags; uses TestInfo for per-test naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterBalanceThrottling.java JUnit5 lifecycle/assertions + tags; replaces @Ignore with @Disabled.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterAbortAndRSGotKilled.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java JUnit5 lifecycle/assertions + tags; uses TestInfo for per-test naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestLoadProcedureError.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestListTablesByState.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterCommandLine.java JUnit5 assertions + tags (narrows static imports).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestGetReplicationLoad.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestGetLastFlushedSequenceId.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestGetInfoPort.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSFSHLog.java JUnit5 tags (inherits behavior).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSAsyncFSWAL.java JUnit5 tags (inherits behavior).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterStatusPublisher.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestartSplitWithoutZk.java JUnit5 tags (inherits behavior).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestartFailoverSplitWithoutZk.java JUnit5 tags (inherits behavior).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestartFailover.java JUnit5 assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestart.java JUnit5 assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCloseAnOpeningRegion.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java JUnit5 assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClientMetaServiceRPCs.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestBalancer.java JUnit5 lifecycle/assertions + tags; uses TestInfo for per-test naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManagerMetrics.java JUnit5 lifecycle/assertions + tags; uses TestInfo for per-test naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAlwaysStandByHMaster.java Replaces JUnit4 MiniClusterRule with JUnit5 MiniClusterExtension.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java JUnit5 lifecycle/assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestRestartCluster.java JUnit5 lifecycle migration (@BeforeEach/@AfterEach).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestMasterRegionMutation.java New shared base for MasterRegionMutation tests (JUnit5).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestDLS.java JUnit5 lifecycle migration; replaces JUnit4 TestName usage with TestInfo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 78 out of 78 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants