[flink] Fix batch query on empty datalake-enabled table to return 0 rows instead of failing#3208
Open
matrixsparse wants to merge 2 commits intoapache:mainfrom
Open
Conversation
Contributor
Author
|
Thanks for the review! |
Contributor
|
@fresh-borzoni @luoyuxia PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
throws UnsupportedOperationException. This PR makes it return empty result
(0 rows) instead, consistent with Spark connector behavior.
Root Cause
In
FlinkSourceEnumerator.startInBatchMode(),generateHybridLakeFlussSplits()returns null when no lake snapshot exists. The stream mode code in the same
commit (7937996) correctly falls back to
initNonPartitionedSplits(), but thebatch mode path was left to throw an exception.
Change
FlinkSourceEnumerator.java: ReturnCollections.emptyList()instead ofthrowing
UnsupportedOperationExceptionwhen splits is null.Verification
mvnw test -pl fluss-flink/fluss-flink-common -Dtest="FlinkSourceEnumerator*"Fixes #3207