[server] Validate Java version >= 11 in config.sh to prevent silent startup failures#3197
Open
matrixsparse wants to merge 3 commits intoapache:mainfrom
Open
[server] Validate Java version >= 11 in config.sh to prevent silent startup failures#3197matrixsparse wants to merge 3 commits intoapache:mainfrom
matrixsparse wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
Author
Yohahaha
approved these changes
Apr 25, 2026
Contributor
Yohahaha
left a comment
There was a problem hiding this comment.
overall LGTM! thank you, I will verify this fix locally next week.
Contributor
Author
|
Thanks for the review! |
Contributor
|
@matrixsparse thank you for the fix, I have verified this fix works for me. one minor comments, we already have |
Contributor
Author
|
@Yohahaha Thanks for the review! I've merged is_jdk_version_ge_11 and is_jdk_version_ge_17 into a single parameterized function is_jdk_version_ge(). PTAL again, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_jdk_version_ge_11()function inconfig.shto validate Java versionJAVA_RUNresolution, before any process startupTest Plan
bash -nsyntax check passes on config.sh, coordinator-server.sh, tablet-server.sh, local-cluster.shFixes #3192