[chore] reduce workers to 2 with loadfile distribution#529
Merged
leekeiabstraction merged 1 commit intoapache:mainfrom May 3, 2026
Merged
[chore] reduce workers to 2 with loadfile distribution#529leekeiabstraction merged 1 commit intoapache:mainfrom
leekeiabstraction merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
not sure how much it will help, but i think it can help a bit, maybe we can give it a try? WDYT? @leekeiabstraction @fresh-borzoni there are some other improvements can be made too to improve test stability, and can share later. |
Contributor
Author
|
otherwise, i can close this PR 😄 |
fresh-borzoni
approved these changes
May 3, 2026
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
Thank you, let's try this as a quick fix, if you can propose some improvements in tests - also much appreciated 👍
leekeiabstraction
approved these changes
May 3, 2026
Contributor
|
TY for the quick workaround! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By a quick look, i have some ideas of where test flake can happen, and i think we can reduce concurrent workers from 4 to 2 (given unbuntu-latest probably has 4 cores)
Plus, i think usually
loadfilecould be a better distribution strategy than the default in concurrent runs scenario since tests from the same file will go to same worker now.