[python]: Add nullability support for data type in python#522
Merged
leekeiabstraction merged 2 commits intoapache:mainfrom May 3, 2026
Merged
[python]: Add nullability support for data type in python#522leekeiabstraction merged 2 commits intoapache:mainfrom
leekeiabstraction merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@fresh-borzoni @leekeiabstraction if you have time, PTAL 🙏 thanks! |
fresh-borzoni
approved these changes
May 2, 2026
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@charlesdong1991 Ty for the PR, LGTM 👍
Contributor
|
I'm waiting for syncing Cargo.lock and then we can rebase and merge 👍 |
Contributor
Author
|
Seems Cargo.lock PR has been merged! i did a rebase to sync |
leekeiabstraction
approved these changes
May 3, 2026
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
LGTM, TY for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Preserve PyArrow field nullability when constructing Fluss schemas. Previously, field.is_nullable() was ignored and all types defaulted to nullable.
Linked issue: close #511
Tests
All tests have passed
API and Format
Documentation