[client] Implement BatchScanner with limit-based scan#515
Open
Arnav-panjla wants to merge 3 commits intoapache:mainfrom
Open
[client] Implement BatchScanner with limit-based scan#515Arnav-panjla wants to merge 3 commits intoapache:mainfrom
Arnav-panjla wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@Arnav-panjla Ty for the PR, left some comments, PTAL
| "rustc_version", | ||
| ] | ||
|
|
||
| [[package]] |
Contributor
There was a problem hiding this comment.
let's sync Cargo.lock in a separate PR, otherwise it's weird.
Want to pick this up?
| @@ -0,0 +1,254 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
Contributor
There was a problem hiding this comment.
We don't have any tests, do you mind to add unit and integration tests?
| Ok(self | ||
| .batch | ||
| .take() | ||
| .map(|b| ScanBatch::new(self.bucket.clone(), b, 0))) |
Contributor
There was a problem hiding this comment.
why do we hardcode 0 here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #316
Implement one-shot
BatchScannerusingLimitScanRequest.Brief change log
limittoTableScancreate_batch_scannerBatchScanner(eager RPC, singlepoll_batch)RecordBatch(PK) decodingTests
cargo test)cargo check,clippy,fmtAPI and Format
API Change: Yes
BatchScanner,TableScan::limit,create_batch_scannerStorage Format: No
Documentation
No