Skip to content

[hotfix] Fix grammatical errors in Materialized Table and related code#28050

Open
rmoff wants to merge 1 commit intoapache:masterfrom
rmoff:fix/materialized-table-grammar
Open

[hotfix] Fix grammatical errors in Materialized Table and related code#28050
rmoff wants to merge 1 commit intoapache:masterfrom
rmoff:fix/materialized-table-grammar

Conversation

@rmoff
Copy link
Copy Markdown
Contributor

@rmoff rmoff commented Apr 27, 2026

Summary

  • Fix 17 instances of "X occur exception" (subject-verb disagreement) across error messages, log messages, comments, and Javadoc. Replaced with idiomatic "Error doing X" / "Failed to X" phrasing.
  • Fix "Begin to refreshing" to "Beginning to refresh" (incorrect verb form)
  • Fix "doesn't exists" to "doesn't exist" (incorrect conjugation)

Fix "occur exception" pattern (subject-verb disagreement) across error
messages, log messages, comments, and Javadoc. Also fix "Begin to
refreshing" (incorrect verb form) and "doesn't exists" (incorrect
conjugation).
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Apr 27, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin
Copy link
Copy Markdown
Contributor

thanks for your contribution @rmoff
since you changed java file then need to apply spotless
this is exactly the reason why CI is failing for this PR
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=74572&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=236755

try {
LOG.info(
"Begin to refreshing the materialized table {}, statement: {}",
"Beginning to refresh the materialized table {}, statement: {}",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: While "Beginning to refresh" is correct, "Starting to refresh" or "Starting refresh of..." is more idiomatic. eg Starting allocation of slot

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants