Skip to content

[FLINK-39548][table-planner] Fix projected primary key indices for ch…#28042

Open
ljw-hit wants to merge 1 commit intoapache:masterfrom
ljw-hit:fix-source-scan-output-type
Open

[FLINK-39548][table-planner] Fix projected primary key indices for ch…#28042
ljw-hit wants to merge 1 commit intoapache:masterfrom
ljw-hit:fix-source-scan-output-type

Conversation

@ljw-hit
Copy link
Copy Markdown

@ljw-hit ljw-hit commented Apr 27, 2026

…angelog sources

This fixes CommonExecTableSourceScan to derive primary key indices from the projected output type instead of the physical row type. Queries that reorder projected columns for changelog sources now keep the source partitioner aligned with the declared primary key fields.

The change also adds a regression test that validates the partitioner extracts keys from the projected row in the expected primary key order.

Generated-by: TraeCli (GPT-5.4)

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

…angelog sources

This fixes CommonExecTableSourceScan to derive primary key indices from the
projected output type instead of the physical row type. Queries that reorder
projected columns for changelog sources now keep the source partitioner aligned
with the declared primary key fields.

The change also adds a regression test that validates the partitioner extracts
keys from the projected row in the expected primary key order.

Generated-by: TraeCli (GPT-5.4)
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Apr 27, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants